Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71c19024 authored by Jiong Wang's avatar Jiong Wang Committed by Daniel Borkmann
Browse files

nfp: bpf: fix code-gen bug on BPF_ALU | BPF_XOR | BPF_K 



The intended optimization should be A ^ 0 = A, not A ^ -1 = A.

Fixes: cd7df56e ("nfp: add BPF to NFP code translator")
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarJiong Wang <jiong.wang@netronome.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 7c0cdf0b

drivers/net/ethernet/netronome/nfp/bpf/jit.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2309,7 +2309,7 @@ static int xor_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) 




static int xor_imm(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)

static int xor_imm(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)

{

{

	return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !~meta->insn.imm);

	return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !meta->insn.imm);

}

}





static int and_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)

static int and_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)