Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 715edb01 authored by Pietro Borrello's avatar Pietro Borrello Committed by Greg Kroah-Hartman
Browse files

HID: bigben_worker() remove unneeded check on report_field 



[ Upstream commit 27d2a2fd844ec7da70d19fabb482304fd1e0595b ]

bigben_worker() checks report_field to be non-NULL.
The check has been added in commit
918aa1ef104d ("HID: bigbenff: prevent null pointer dereference")
to prevent a NULL pointer crash.
However, the true root cause was a missing check for output
reports, patched in commit
c7bf714f8755 ("HID: check empty report_list in bigben_probe()"),
where the type-confused report list_entry was overlapping with
a NULL pointer, which was then causing the crash.

Fixes: 918aa1ef104d ("HID: bigbenff: prevent null pointer dereference")
Signed-off-by: default avatarPietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230125-hid-unregister-leds-v4-2-7860c5763c38@diag.uniroma1.it


Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 12533ad8

drivers/hid/hid-bigbenff.c

+1 −1
Original line number Diff line number Diff line
@@ -197,7 +197,7 @@ static void bigben_worker(struct work_struct *work) 
	u32 len;

	unsigned long flags;



	if (bigben->removed || !report_field)

	if (bigben->removed)

		return;



	buf = hid_alloc_report_buf(bigben->report, GFP_KERNEL);