Commit 70c819e4 authored Mar 16, 2019 by Changbin Du Committed by Arnaldo Carvalho de Melo Mar 19, 2019

perf top: Fix error handling in cmd_top()



We should go to the cleanup path, to avoid leaks, detected using gcc's
ASan.

Signed-off-by: Changbin Du <changbin.du@gmail.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20190316080556.3075-9-changbin.du@gmail.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 0dba9e4b

tools/perf/builtin-top.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1617,8 +1617,9 @@ int cmd_top(int argc, const char **argv)
		annotation_config__init();

		symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
		if (symbol__init(NULL) < 0)
		return -1;
		status = symbol__init(NULL);
		if (status < 0)
		goto out_delete_evlist;

		sort__setup_elide(stdout);