Commit 70c55c1a authored Jul 28, 2019 by Colin Ian King Committed by Mauro Carvalho Chehab Aug 14, 2019

media: vsp1: fix memory leak of dl on error return path



Currently when the call vsp1_dl_body_get fails and returns null the
error return path leaks the allocation of dl. Fix this by kfree'ing
dl before returning.

Addresses-Coverity: ("Resource leak")

Fixes: 5d7936b8 ("media: vsp1: Convert display lists to use new body pool")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent b20a6e29

drivers/media/platform/vsp1/vsp1_dl.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -557,8 +557,10 @@ static struct vsp1_dl_list vsp1_dl_list_alloc(struct vsp1_dl_manager dlm)

	/* Get a default body for our list. */		/* Get a default body for our list. */
	dl->body0 = vsp1_dl_body_get(dlm->pool);		dl->body0 = vsp1_dl_body_get(dlm->pool);
	if (!dl->body0)		if (!dl->body0) {
			kfree(dl);
	return NULL;		return NULL;
			}

	header_offset = dl->body0->max_entries * sizeof(*dl->body0->entries);		header_offset = dl->body0->max_entries * sizeof(*dl->body0->entries);