Commit 707518c1 authored Jan 06, 2020 by Trond Myklebust Committed by Greg Kroah-Hartman Feb 24, 2020

sunrpc: Fix potential leaks in sunrpc_cache_unhash()



[ Upstream commit 1d82163714c16ebe09c7a8c9cd3cef7abcc16208 ]

When we unhash the cache entry, we need to handle any pending upcalls
by calling cache_fresh_unlocked().

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 46503858

net/sunrpc/cache.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1888,7 +1888,9 @@ void sunrpc_cache_unhash(struct cache_detail cd, struct cache_head h)
		if (!hlist_unhashed(&h->cache_list)){
		hlist_del_init_rcu(&h->cache_list);
		cd->entries--;
		set_bit(CACHE_CLEANED, &h->flags);
		spin_unlock(&cd->hash_lock);
		cache_fresh_unlocked(h, cd);
		cache_put(h, cd);
		} else
		spin_unlock(&cd->hash_lock);