Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 705c8160 authored by Dan Carpenter's avatar Dan Carpenter Committed by Daniel Vetter
Browse files

drm: Fix an error pointer dereference() 



The drm_mode_create_tile_group() is only called from
drm_parse_tiled_block() and the caller expects it to return a NULL on
error.  In other words, this function should match
drm_mode_get_tile_group().

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181217065733.GA12159@kadam
parent 706246c7

drivers/gpu/drm/drm_connector.c

+3 −3
Original line number Diff line number Diff line
@@ -1960,7 +1960,7 @@ EXPORT_SYMBOL(drm_mode_get_tile_group); 
 * identifier for the tile group.

 *

 * RETURNS:

 * new tile group or error.

 * new tile group or NULL.

 */

struct drm_tile_group *drm_mode_create_tile_group(struct drm_device *dev,

						  char topology[8])
@@ -1970,7 +1970,7 @@ struct drm_tile_group *drm_mode_create_tile_group(struct drm_device *dev, 


	tg = kzalloc(sizeof(*tg), GFP_KERNEL);

	if (!tg)

		return ERR_PTR(-ENOMEM);

		return NULL;



	kref_init(&tg->refcount);

	memcpy(tg->group_data, topology, 8);
@@ -1982,7 +1982,7 @@ struct drm_tile_group *drm_mode_create_tile_group(struct drm_device *dev, 
		tg->id = ret;

	} else {

		kfree(tg);

		tg = ERR_PTR(ret);

		tg = NULL;

	}



	mutex_unlock(&dev->mode_config.idr_mutex);