Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 70433b90 authored by Ben Skeggs's avatar Ben Skeggs
Browse files

drm/nouveau/bar/gm107-: wait for instance block binding to complete 



Discovered by accident while working to use BAR2 access to instmem objects
on more paths.

We've apparently been relying on luck up until now!

Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent 8e644cb2

drivers/gpu/drm/nouveau/include/nvkm/subdev/bar.h

+2 −0
Original line number Diff line number Diff line
@@ -24,4 +24,6 @@ int nv50_bar_new(struct nvkm_device *, int, struct nvkm_bar **); 
int g84_bar_new(struct nvkm_device *, int, struct nvkm_bar **);

int gf100_bar_new(struct nvkm_device *, int, struct nvkm_bar **);

int gk20a_bar_new(struct nvkm_device *, int, struct nvkm_bar **);

int gm107_bar_new(struct nvkm_device *, int, struct nvkm_bar **);

int gm20b_bar_new(struct nvkm_device *, int, struct nvkm_bar **);

#endif

drivers/gpu/drm/nouveau/nvkm/engine/device/base.c

+13 −13
Original line number Diff line number Diff line
@@ -1958,7 +1958,7 @@ nv108_chipset = { 
static const struct nvkm_device_chip

nv117_chipset = {

	.name = "GM107",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.clk = gk104_clk_new,
@@ -1992,7 +1992,7 @@ nv117_chipset = { 
static const struct nvkm_device_chip

nv118_chipset = {

	.name = "GM108",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.clk = gk104_clk_new,
@@ -2026,7 +2026,7 @@ nv118_chipset = { 
static const struct nvkm_device_chip

nv120_chipset = {

	.name = "GM200",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2061,7 +2061,7 @@ nv120_chipset = { 
static const struct nvkm_device_chip

nv124_chipset = {

	.name = "GM204",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2096,7 +2096,7 @@ nv124_chipset = { 
static const struct nvkm_device_chip

nv126_chipset = {

	.name = "GM206",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2131,7 +2131,7 @@ nv126_chipset = { 
static const struct nvkm_device_chip

nv12b_chipset = {

	.name = "GM20B",

	.bar = gk20a_bar_new,

	.bar = gm20b_bar_new,

	.bus = gf100_bus_new,

	.clk = gm20b_clk_new,

	.fb = gm20b_fb_new,
@@ -2156,7 +2156,7 @@ nv12b_chipset = { 
static const struct nvkm_device_chip

nv130_chipset = {

	.name = "GP100",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2191,7 +2191,7 @@ nv130_chipset = { 
static const struct nvkm_device_chip

nv132_chipset = {

	.name = "GP102",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2226,7 +2226,7 @@ nv132_chipset = { 
static const struct nvkm_device_chip

nv134_chipset = {

	.name = "GP104",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2261,7 +2261,7 @@ nv134_chipset = { 
static const struct nvkm_device_chip

nv136_chipset = {

	.name = "GP106",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2296,7 +2296,7 @@ nv136_chipset = { 
static const struct nvkm_device_chip

nv137_chipset = {

	.name = "GP107",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2331,7 +2331,7 @@ nv137_chipset = { 
static const struct nvkm_device_chip

nv138_chipset = {

	.name = "GP108",

	.bar = gf100_bar_new,

	.bar = gm107_bar_new,

	.bios = nvkm_bios_new,

	.bus = gf100_bus_new,

	.devinit = gm200_devinit_new,
@@ -2361,7 +2361,7 @@ nv138_chipset = { 
static const struct nvkm_device_chip

nv13b_chipset = {

	.name = "GP10B",

	.bar = gk20a_bar_new,

	.bar = gm20b_bar_new,

	.bus = gf100_bus_new,

	.fb = gp10b_fb_new,

	.fuse = gm107_fuse_new,

drivers/gpu/drm/nouveau/nvkm/subdev/bar/Kbuild

+2 −0
Original line number Diff line number Diff line
@@ -3,3 +3,5 @@ nvkm-y += nvkm/subdev/bar/nv50.o 
nvkm-y += nvkm/subdev/bar/g84.o

nvkm-y += nvkm/subdev/bar/gf100.o

nvkm-y += nvkm/subdev/bar/gk20a.o

nvkm-y += nvkm/subdev/bar/gm107.o

nvkm-y += nvkm/subdev/bar/gm20b.o

drivers/gpu/drm/nouveau/nvkm/subdev/bar/gm107.c

0 → 100644
+65 −0
Original line number Diff line number Diff line 
/*

 * Copyright 2017 Red Hat Inc.

 *

 * Permission is hereby granted, free of charge, to any person obtaining a

 * copy of this software and associated documentation files (the "Software"),

 * to deal in the Software without restriction, including without limitation

 * the rights to use, copy, modify, merge, publish, distribute, sublicense,

 * and/or sell copies of the Software, and to permit persons to whom the

 * Software is furnished to do so, subject to the following conditions:

 *

 * The above copyright notice and this permission notice shall be included in

 * all copies or substantial portions of the Software.

 *

 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,

 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL

 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR

 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,

 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR

 * OTHER DEALINGS IN THE SOFTWARE.

 */

#include "gf100.h"



#include <subdev/timer.h>



void

gm107_bar_bar1_wait(struct nvkm_bar *bar)

{

	struct nvkm_device *device = bar->subdev.device;

	nvkm_msec(device, 2000,

		if (!(nvkm_rd32(device, 0x001710) & 0x00000003))

			break;

	);

}



static void

gm107_bar_bar2_wait(struct nvkm_bar *bar)

{

	struct nvkm_device *device = bar->subdev.device;

	nvkm_msec(device, 2000,

		if (!(nvkm_rd32(device, 0x001710) & 0x0000000c))

			break;

	);

}



static const struct nvkm_bar_func

gm107_bar_func = {

	.dtor = gf100_bar_dtor,

	.oneinit = gf100_bar_oneinit,

	.bar1.init = gf100_bar_bar1_init,

	.bar1.fini = gf100_bar_bar1_fini,

	.bar1.wait = gm107_bar_bar1_wait,

	.bar1.vmm = gf100_bar_bar1_vmm,

	.bar2.init = gf100_bar_bar2_init,

	.bar2.fini = gf100_bar_bar2_fini,

	.bar2.wait = gm107_bar_bar2_wait,

	.bar2.vmm = gf100_bar_bar2_vmm,

	.flush = g84_bar_flush,

};



int

gm107_bar_new(struct nvkm_device *device, int index, struct nvkm_bar **pbar)

{

	return gf100_bar_new_(&gm107_bar_func, device, index, pbar);

}

drivers/gpu/drm/nouveau/nvkm/subdev/bar/gm20b.c

0 → 100644
+42 −0
Original line number Diff line number Diff line 
/*

 * Copyright 2017 Red Hat Inc.

 *

 * Permission is hereby granted, free of charge, to any person obtaining a

 * copy of this software and associated documentation files (the "Software"),

 * to deal in the Software without restriction, including without limitation

 * the rights to use, copy, modify, merge, publish, distribute, sublicense,

 * and/or sell copies of the Software, and to permit persons to whom the

 * Software is furnished to do so, subject to the following conditions:

 *

 * The above copyright notice and this permission notice shall be included in

 * all copies or substantial portions of the Software.

 *

 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,

 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL

 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR

 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,

 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR

 * OTHER DEALINGS IN THE SOFTWARE.

 */

#include "gf100.h"



static const struct nvkm_bar_func

gm20b_bar_func = {

	.dtor = gf100_bar_dtor,

	.oneinit = gf100_bar_oneinit,

	.bar1.init = gf100_bar_bar1_init,

	.bar1.fini = gf100_bar_bar1_fini,

	.bar1.wait = gm107_bar_bar1_wait,

	.bar1.vmm = gf100_bar_bar1_vmm,

	.flush = g84_bar_flush,

};



int

gm20b_bar_new(struct nvkm_device *device, int index, struct nvkm_bar **pbar)

{

	int ret = gf100_bar_new_(&gm20b_bar_func, device, index, pbar);

	if (ret == 0)

		(*pbar)->iomap_uncached = true;

	return ret;

}