Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 702d1e81 authored by Terry Zhou's avatar Terry Zhou Committed by Linus Walleij
Browse files

pinctrl: armada-37xx: Fix spurious irq management 



Until now, if we found spurious irq in irq_handler, we only updated the
status in register but not the status in the code. Due to this the system
will got stuck dues to the infinite loop

[gregory.clement@bootlin.com: update comment and add fix and stable tags]
Fixes: 30ac0d3b ("pinctrl: armada-37xx: Add edge both type gpio irq support")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTerry Zhou <bjzhou@marvell.com>
Reviewed-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 973c1714

drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

+2 −1
Original line number Diff line number Diff line
@@ -666,12 +666,13 @@ static void armada_37xx_irq_handler(struct irq_desc *desc) 
					writel(1 << hwirq,

					       info->base +

					       IRQ_STATUS + 4 * i);

					continue;

					goto update_status;

				}

			}



			generic_handle_irq(virq);



update_status:

			/* Update status in case a new IRQ appears */

			spin_lock_irqsave(&info->irq_lock, flags);

			status = readl_relaxed(info->base +