Commit 6fdd36fb authored Aug 07, 2024 by Csókás, Bence Committed by Greg Kroah-Hartman Aug 19, 2024

net: fec: Stop PPS on driver remove



[ Upstream commit 8fee6d5ad5fa18c270eedb2a2cdf58dbadefb94b ]

PPS was not stopped in `fec_ptp_stop()`, called when
the adapter was removed. Consequentially, you couldn't
safely reload the driver with the PPS signal on.

Fixes: 32cba57b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/netdev/CAOMZO5BzcZR8PwKKwBssQq_wAGzVgf1ffwe_nhpQJjviTdxy-w@mail.gmail.com/T/#m01dcb810bfc451a492140f6797ca77443d0cb79f


Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20240807080956.2556602-1-csokas.bence@prolan.hu


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent d89b1a93

drivers/net/ethernet/freescale/fec_ptp.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -635,6 +635,9 @@ void fec_ptp_stop(struct platform_device *pdev)
		struct net_device *ndev = platform_get_drvdata(pdev);
		struct fec_enet_private *fep = netdev_priv(ndev);

		if (fep->pps_enable)
		fec_ptp_enable_pps(fep, 0);

		cancel_delayed_work_sync(&fep->time_keep);
		if (fep->ptp_clock)
		ptp_clock_unregister(fep->ptp_clock);