Commit 6fa4e299 authored Dec 20, 2021 by Benjamin Tissoires Committed by Greg Kroah-Hartman Dec 29, 2021

HID: holtek: fix mouse probing

commit 93a2207c254ca102ebbdae47b00f19bbfbfa7ecd upstream.

An overlook from the previous commit: we don't even parse or start the
device, meaning that the device is not presented to user space.

Fixes: 93020953d0fa ("HID: check for valid USB device for many HID drivers")
Cc: stable@vger.kernel.org
Link: https://bugs.archlinux.org/task/73048
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215341
Link: https://lore.kernel.org/r/e4efbf13-bd8d-0370-629b-6c80c0044b15@leemhuis.info/


Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2712816c

drivers/hid/hid-holtek-mouse.c

+15 −0

Original line number	Diff line number	Diff line
		@@ -65,8 +65,23 @@ static __u8 holtek_mouse_report_fixup(struct hid_device hdev, __u8 *rdesc,
		static int holtek_mouse_probe(struct hid_device *hdev,
		const struct hid_device_id *id)
		{
		int ret;

		if (!hid_is_usb(hdev))
		return -EINVAL;

		ret = hid_parse(hdev);
		if (ret) {
		hid_err(hdev, "hid parse failed: %d\n", ret);
		return ret;
		}

		ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
		if (ret) {
		hid_err(hdev, "hw start failed: %d\n", ret);
		return ret;
		}

		return 0;
		}