Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f4a1eef authored by Eric Sandeen's avatar Eric Sandeen Committed by Darrick J. Wong
Browse files

xfs: toggle readonly state around xfs_log_mount_finish 



When we do log recovery on a readonly mount, unlinked inode
processing does not happen due to the readonly checks in
xfs_inactive(), which are trying to prevent any I/O on a
readonly mount.

This is misguided - we do I/O on readonly mounts all the time,
for consistency; for example, log recovery.  So do the same
RDONLY flag twiddling around xfs_log_mount_finish() as we
do around xfs_log_mount(), for the same reason.

This all cries out for a big rework but for now this is a
simple fix to an obvious problem.

Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 757a69ef

fs/xfs/xfs_log.c

+7 −0
Original line number Diff line number Diff line
@@ -743,10 +743,14 @@ xfs_log_mount_finish( 
	struct xfs_mount	*mp)

{

	int	error = 0;

	bool	readonly = (mp->m_flags & XFS_MOUNT_RDONLY);



	if (mp->m_flags & XFS_MOUNT_NORECOVERY) {

		ASSERT(mp->m_flags & XFS_MOUNT_RDONLY);

		return 0;

	} else if (readonly) {

		/* Allow unlinked processing to proceed */

		mp->m_flags &= ~XFS_MOUNT_RDONLY;

	}



	/*
@@ -764,6 +768,9 @@ xfs_log_mount_finish( 
		xfs_log_work_queue(mp);

	mp->m_super->s_flags &= ~MS_ACTIVE;



	if (readonly)

		mp->m_flags |= XFS_MOUNT_RDONLY;



	return error;

}