Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f3de838 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mauro Carvalho Chehab
Browse files

media: omap3isp: fix warning for !CONFIG_PM 



The final version of the COMPILE_TEST patch for this driver missed
one warning about suspend/resume functions that can now appear
on platforms that don't always set CONFIG_PM:

drivers/media/platform/omap3isp/isp.c:1008:13: error: 'isp_resume_modules' defined but not used [-Werror=unused-function]
 static void isp_resume_modules(struct isp_device *isp)
             ^~~~~~~~~~~~~~~~~~
drivers/media/platform/omap3isp/isp.c:974:12: error: 'isp_suspend_modules' defined but not used [-Werror=unused-function]
 static int isp_suspend_modules(struct isp_device *isp)

This marks the respective functions as __maybe_unused as an easy
workaround.

Fixes: 24313113 ("media: omap3isp: Allow it to build with COMPILE_TEST")

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 795bce43

drivers/media/platform/omap3isp/isp.c

+2 −2
Original line number Diff line number Diff line
@@ -971,7 +971,7 @@ static void isp_resume_module_pipeline(struct media_entity *me) 
 * Returns 0 if suspend left in idle state all the submodules properly,

 * or returns 1 if a general Reset is required to suspend the submodules.

 */

static int isp_suspend_modules(struct isp_device *isp)

static int __maybe_unused isp_suspend_modules(struct isp_device *isp)

{

	unsigned long timeout;
@@ -1005,7 +1005,7 @@ static int isp_suspend_modules(struct isp_device *isp) 
 * isp_resume_modules - Resume ISP submodules.

 * @isp: OMAP3 ISP device

 */

static void isp_resume_modules(struct isp_device *isp)

static void __maybe_unused isp_resume_modules(struct isp_device *isp)

{

	omap3isp_stat_resume(&isp->isp_aewb);

	omap3isp_stat_resume(&isp->isp_af);