Commit 6efe3961 authored Dec 17, 2021 by Xiaoke Wang Committed by Greg Kroah-Hartman Feb 16, 2022

nfs: nfs4clinet: check the return value of kstrdup()



[ Upstream commit fbd2057e5329d3502a27491190237b6be52a1cb6 ]

kstrdup() returns NULL when some internal memory errors happen, it is
better to check the return value of it so to catch the memory error in
time.

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2acac498

fs/nfs/nfs4client.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1293,8 +1293,11 @@ int nfs4_update_server(struct nfs_server server, const char hostname,
		}
		nfs_put_client(clp);

		if (server->nfs_client->cl_hostname == NULL)
		if (server->nfs_client->cl_hostname == NULL) {
		server->nfs_client->cl_hostname = kstrdup(hostname, GFP_KERNEL);
		if (server->nfs_client->cl_hostname == NULL)
		return -ENOMEM;
		}
		nfs_server_insert_lists(server);

		return nfs_probe_destination(server);