Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6edf0747 authored by Ryder Lee's avatar Ryder Lee Committed by Felix Fietkau
Browse files

mt76: add unlikely() for dma_mapping_error() check 



In the tx/rx fastpath, the funciton dma_map_single() rarely fails.
This adds unlikely() optimization to this error check conditional.

Signed-off-by: default avatarRyder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 04b8e659

drivers/net/wireless/mediatek/mt76/dma.c

+4 −4
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ mt76_dma_tx_queue_skb_raw(struct mt76_dev *dev, enum mt76_txq_id qid, 


	addr = dma_map_single(dev->dev, skb->data, skb->len,

			      DMA_TO_DEVICE);

	if (dma_mapping_error(dev->dev, addr))

	if (unlikely(dma_mapping_error(dev->dev, addr)))

		return -ENOMEM;



	buf.addr = addr;
@@ -315,7 +315,7 @@ mt76_dma_tx_queue_skb(struct mt76_dev *dev, enum mt76_txq_id qid, 


	len = skb_headlen(skb);

	addr = dma_map_single(dev->dev, skb->data, len, DMA_TO_DEVICE);

	if (dma_mapping_error(dev->dev, addr))

	if (unlikely(dma_mapping_error(dev->dev, addr)))

		goto free;



	tx_info.buf[n].addr = t->dma_addr;
@@ -329,7 +329,7 @@ mt76_dma_tx_queue_skb(struct mt76_dev *dev, enum mt76_txq_id qid, 


		addr = dma_map_single(dev->dev, iter->data, iter->len,

				      DMA_TO_DEVICE);

		if (dma_mapping_error(dev->dev, addr))

		if (unlikely(dma_mapping_error(dev->dev, addr)))

			goto unmap;



		tx_info.buf[n].addr = addr;
@@ -386,7 +386,7 @@ mt76_dma_rx_fill(struct mt76_dev *dev, struct mt76_queue *q) 
			break;



		addr = dma_map_single(dev->dev, buf, len, DMA_FROM_DEVICE);

		if (dma_mapping_error(dev->dev, addr)) {

		if (unlikely(dma_mapping_error(dev->dev, addr))) {

			skb_free_frag(buf);

			break;

		}