Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d2e68d0 authored by Zheyu Ma's avatar Zheyu Ma Committed by Greg Kroah-Hartman
Browse files

iio: gyro: mpu3050: Fix the error handling in mpu3050_power_up() 



commit b2f5ad97645e1deb5ca9bcb7090084b92cae35d2 upstream.

The driver should disable regulators when fails at regmap_update_bits().

Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Cc: <Stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220510092431.1711284-1-zheyuma97@gmail.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1ad6d668

drivers/iio/gyro/mpu3050-core.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -874,6 +874,7 @@ static int mpu3050_power_up(struct mpu3050 *mpu3050) 
	ret = regmap_update_bits(mpu3050->map, MPU3050_PWR_MGM,

	ret = regmap_update_bits(mpu3050->map, MPU3050_PWR_MGM,

				 MPU3050_PWR_MGM_SLEEP, 0);

				 MPU3050_PWR_MGM_SLEEP, 0);

	if (ret) {

	if (ret) {

		regulator_bulk_disable(ARRAY_SIZE(mpu3050->regs), mpu3050->regs);

		dev_err(mpu3050->dev, "error setting power mode\n");

		dev_err(mpu3050->dev, "error setting power mode\n");

		return ret;

		return ret;

	}

	}