Commit 6d028ade authored Nov 13, 2023 by Anastasia Belova Committed by Greg Kroah-Hartman Nov 28, 2023

cifs: spnego: add ';' in HOST_KEY_LEN



[ Upstream commit ff31ba19d732efb9aca3633935d71085e68d5076 ]

"host=" should start with ';' (as in cifs_get_spnego_key)
So its length should be 6.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Fixes: 7c9c3760 ("[CIFS] add constants for string lengths of keynames in SPNEGO upcall string")
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
Co-developed-by: Ekaterina Esina <eesina@astralinux.ru>
Signed-off-by: Ekaterina Esina <eesina@astralinux.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 26415e35

fs/cifs/cifs_spnego.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -76,8 +76,8 @@ struct key_type cifs_spnego_key_type = {
		* strlen(";sec=ntlmsspi") */
		#define MAX_MECH_STR_LEN 13

		/* strlen of "host=" */
		#define HOST_KEY_LEN 5
		/* strlen of ";host=" */
		#define HOST_KEY_LEN 6

		/* strlen of ";ip4=" or ";ip6=" */
		#define IP_KEY_LEN 5