Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ccd228e authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: fimc-capture: get rid of two warnings 



Smatch produces two warnings when building this file:
	./arch/x86/include/asm/bitops.h:433:22: warning: asm output is not an lvalue
	./arch/x86/include/asm/bitops.h:433:22: warning: asm output is not an lvalue

On some asm instructions.

I suspect that those asm instructions might not be producing the
right code, so, better to use two intermediate vars, get rid of
the warnings and of the risk of producing a wrong code.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 0d2a531d

drivers/media/platform/exynos4-is/fimc-capture.c

+5 −2
Original line number Diff line number Diff line
@@ -670,10 +670,13 @@ static void fimc_capture_try_selection(struct fimc_ctx *ctx, 
		return;

	}

	if (target == V4L2_SEL_TGT_COMPOSE) {

		u32 tmp_min_h = ffs(sink->width) - 3;

		u32 tmp_min_v = ffs(sink->height) - 1;



		if (ctx->rotation != 90 && ctx->rotation != 270)

			align_h = 1;

		max_sc_h = min(SCALER_MAX_HRATIO, 1 << (ffs(sink->width) - 3));

		max_sc_v = min(SCALER_MAX_VRATIO, 1 << (ffs(sink->height) - 1));

		max_sc_h = min(SCALER_MAX_HRATIO, 1 << tmp_min_h);

		max_sc_v = min(SCALER_MAX_VRATIO, 1 << tmp_min_v);

		min_sz = var->min_out_pixsize;

	} else {

		u32 depth = fimc_get_format_depth(sink->fmt);