Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c8b1208 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: altera: Remove redundant platform_get_resource() return value check 



devm_ioremap_resource() fails gracefully when given a NULL resource
pointer, so we don't need to check separately for failure from
platform_get_resource_byname().  Remove the redundant check.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent ce4f1c7a

drivers/pci/host/pcie-altera-msi.c

+0 −10
Original line number Diff line number Diff line
@@ -237,11 +237,6 @@ static int altera_msi_probe(struct platform_device *pdev) 
	msi->pdev = pdev;



	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr");

	if (!res) {

		dev_err(&pdev->dev, "no csr memory resource defined\n");

		return -ENODEV;

	}



	msi->csr_base = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(msi->csr_base)) {

		dev_err(&pdev->dev, "failed to map csr memory\n");
@@ -250,11 +245,6 @@ static int altera_msi_probe(struct platform_device *pdev) 


	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,

					   "vector_slave");

	if (!res) {

		dev_err(&pdev->dev, "no vector_slave memory resource defined\n");

		return -ENODEV;

	}



	msi->vector_base = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(msi->vector_base)) {

		dev_err(&pdev->dev, "failed to map vector_slave memory\n");