Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c7515c6 authored by Ralph Sennhauser's avatar Ralph Sennhauser Committed by Linus Walleij
Browse files

gpio: mvebu: change compatible string for PWM support 



As it turns out more than just Armada 370 and XP support using GPIO
lines as PWM lines. For example the Armada 38x family has the same
hardware support. As such "marvell,armada-370-xp-gpio" for the
compatible string is a misnomer.

Change the compatible string to "marvell,armada-370-gpio" before the
driver makes it out of the -rc stage. This also follows the practice of
using only the first device family supported as part of the name.

Also update the documentation and comments in the code accordingly.

Fixes: 757642f9 ("gpio: mvebu: Add limited PWM support")
Signed-off-by: default avatarRalph Sennhauser <ralph.sennhauser@gmail.com>
Acked-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 41f1830f

Documentation/devicetree/bindings/gpio/gpio-mvebu.txt

+3 −3
Original line number Diff line number Diff line
@@ -41,9 +41,9 @@ Required properties: 
Optional properties:



In order to use the GPIO lines in PWM mode, some additional optional

properties are required. Only Armada 370 and XP support these properties.

properties are required.



- compatible: Must contain "marvell,armada-370-xp-gpio"

- compatible: Must contain "marvell,armada-370-gpio"



- reg: an additional register set is needed, for the GPIO Blink

  Counter on/off registers.
@@ -71,7 +71,7 @@ Example: 
		};



		gpio1: gpio@18140 {

			compatible = "marvell,armada-370-xp-gpio";

			compatible = "marvell,armada-370-gpio";

			reg = <0x18140 0x40>, <0x181c8 0x08>;

			reg-names = "gpio", "pwm";

			ngpios = <17>;

drivers/gpio/gpio-mvebu.c

+3 −3
Original line number Diff line number Diff line
@@ -721,7 +721,7 @@ static int mvebu_pwm_probe(struct platform_device *pdev, 
	u32 set;



	if (!of_device_is_compatible(mvchip->chip.of_node,

				     "marvell,armada-370-xp-gpio"))

				     "marvell,armada-370-gpio"))

		return 0;



	if (IS_ERR(mvchip->clk))
@@ -852,7 +852,7 @@ static const struct of_device_id mvebu_gpio_of_match[] = { 
		.data	    = (void *) MVEBU_GPIO_SOC_VARIANT_ARMADAXP,

	},

	{

		.compatible = "marvell,armada-370-xp-gpio",

		.compatible = "marvell,armada-370-gpio",

		.data	    = (void *) MVEBU_GPIO_SOC_VARIANT_ORION,

	},

	{
@@ -1128,7 +1128,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev) 
						 mvchip);

	}



	/* Armada 370/XP has simple PWM support for GPIO lines */

	/* Some MVEBU SoCs have simple PWM support for GPIO lines */

	if (IS_ENABLED(CONFIG_PWM))

		return mvebu_pwm_probe(pdev, mvchip, id);