Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c64460c authored by Arnd Bergmann's avatar Arnd Bergmann Committed by David Sterba
Browse files

btrfs: shut up bogus -Wmaybe-uninitialized warning 



gcc sometimes can't determine whether a variable has been initialized
when both the initialization and the use are conditional:

fs/btrfs/props.c: In function 'inherit_props':
fs/btrfs/props.c:389:4: error: 'num_bytes' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    btrfs_block_rsv_release(fs_info, trans->block_rsv,

This code is fine. Unfortunately, I cannot think of a good way to
rephrase it in a way that makes gcc understand this, so I add a bogus
initialization the way one should not.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
[ gcc 8 and 9 don't emit the warning ]
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 9e967495

fs/btrfs/props.c

+1 −1
Original line number Diff line number Diff line
@@ -337,7 +337,7 @@ static int inherit_props(struct btrfs_trans_handle *trans, 
	for (i = 0; i < ARRAY_SIZE(prop_handlers); i++) {

		const struct prop_handler *h = &prop_handlers[i];

		const char *value;

		u64 num_bytes;

		u64 num_bytes = 0;



		if (!h->inheritable)

			continue;