Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c2faeaa authored by Bart Van Assche's avatar Bart Van Assche Committed by Nicholas Bellinger
Browse files

target: Add missing parentheses 



Code like " &= ~CMD_T_BUSY | ..." only clears CMD_T_BUSY but not
the other flag. Modify these statements such that both flags are
cleared.

(Fix fuzz for target_write_prot_action code in mainline - nab)

Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 63509c60

drivers/target/target_core_transport.c

+2 −2
Original line number Diff line number Diff line
@@ -1770,7 +1770,7 @@ static int target_write_prot_action(struct se_cmd *cmd) 
						   sectors, 0, NULL, 0);

		if (unlikely(cmd->pi_err)) {

			spin_lock_irq(&cmd->t_state_lock);

			cmd->transport_state &= ~CMD_T_BUSY|CMD_T_SENT;

			cmd->transport_state &= ~(CMD_T_BUSY|CMD_T_SENT);

			spin_unlock_irq(&cmd->t_state_lock);

			transport_generic_request_failure(cmd, cmd->pi_err);

			return -1;
@@ -1868,7 +1868,7 @@ void target_execute_cmd(struct se_cmd *cmd) 


	if (target_handle_task_attr(cmd)) {

		spin_lock_irq(&cmd->t_state_lock);

		cmd->transport_state &= ~CMD_T_BUSY|CMD_T_SENT;

		cmd->transport_state &= ~(CMD_T_BUSY | CMD_T_SENT);

		spin_unlock_irq(&cmd->t_state_lock);

		return;

	}