Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c22a119 authored by Or Gerlitz's avatar Or Gerlitz Committed by Saeed Mahameed
Browse files

net/mlx5: Remove the get protocol device interface entry 



This isn't used anywhere across the mlx5 driver stack,
remove it.

Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent a2c6162b

drivers/net/ethernet/mellanox/mlx5/core/dev.c

+0 −22
Original line number Diff line number Diff line
@@ -256,28 +256,6 @@ void mlx5_reload_interface(struct mlx5_core_dev *mdev, int protocol) 
	mutex_unlock(&mlx5_intf_mutex);

}



void *mlx5_get_protocol_dev(struct mlx5_core_dev *mdev, int protocol)

{

	struct mlx5_priv *priv = &mdev->priv;

	struct mlx5_device_context *dev_ctx;

	unsigned long flags;

	void *result = NULL;



	spin_lock_irqsave(&priv->ctx_lock, flags);



	list_for_each_entry(dev_ctx, &mdev->priv.ctx_list, list)

		if ((dev_ctx->intf->protocol == protocol) &&

		    dev_ctx->intf->get_dev) {

			result = dev_ctx->intf->get_dev(dev_ctx->context);

			break;

		}



	spin_unlock_irqrestore(&priv->ctx_lock, flags);



	return result;

}

EXPORT_SYMBOL(mlx5_get_protocol_dev);



/* Must be called with intf_mutex held */

void mlx5_add_dev_by_protocol(struct mlx5_core_dev *dev, int protocol)

{

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+0 −8
Original line number Diff line number Diff line
@@ -5160,20 +5160,12 @@ static void mlx5e_remove(struct mlx5_core_dev *mdev, void *vpriv) 
	kfree(ppriv);

}



static void *mlx5e_get_netdev(void *vpriv)

{

	struct mlx5e_priv *priv = vpriv;



	return priv->netdev;

}



static struct mlx5_interface mlx5e_interface = {

	.add       = mlx5e_add,

	.remove    = mlx5e_remove,

	.attach    = mlx5e_attach,

	.detach    = mlx5e_detach,

	.protocol  = MLX5_INTERFACE_PROTOCOL_ETH,

	.get_dev   = mlx5e_get_netdev,

};



void mlx5e_init(void)

include/linux/mlx5/driver.h

+0 −2
Original line number Diff line number Diff line
@@ -1004,12 +1004,10 @@ struct mlx5_interface { 
	void			(*remove)(struct mlx5_core_dev *dev, void *context);

	int			(*attach)(struct mlx5_core_dev *dev, void *context);

	void			(*detach)(struct mlx5_core_dev *dev, void *context);

	void *                  (*get_dev)(void *context);

	int			protocol;

	struct list_head	list;

};



void *mlx5_get_protocol_dev(struct mlx5_core_dev *mdev, int protocol);

int mlx5_register_interface(struct mlx5_interface *intf);

void mlx5_unregister_interface(struct mlx5_interface *intf);

int mlx5_notifier_register(struct mlx5_core_dev *dev, struct notifier_block *nb);