Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c1ecba8 authored by Lothar Waßmann's avatar Lothar Waßmann Committed by Shawn Guo
Browse files

video: mxsfb: fix crash when unblanking the display 



The VDCTRL4 register does not provide the MXS SET/CLR/TOGGLE feature.
The write in mxsfb_disable_controller() sets the data_cnt for the LCD
DMA to 0 which obviously means the max. count for the LCD DMA and
leads to overwriting arbitrary memory when the display is unblanked.

Signed-off-by: default avatarLothar Waßmann <LW@KARO-electronics.de>
Acked-by: default avatarJuergen Beisert <jbe@pengutronix.de>
Tested-by: default avatarLauri Hintsala <lauri.hintsala@bluegiga.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
parent 664e9e49

drivers/video/mxsfb.c

+2 −1
Original line number Diff line number Diff line
@@ -369,7 +369,8 @@ static void mxsfb_disable_controller(struct fb_info *fb_info) 
		loop--;

	}



	writel(VDCTRL4_SYNC_SIGNALS_ON, host->base + LCDC_VDCTRL4 + REG_CLR);

	reg = readl(host->base + LCDC_VDCTRL4);

	writel(reg & ~VDCTRL4_SYNC_SIGNALS_ON, host->base + LCDC_VDCTRL4);



	clk_disable_unprepare(host->clk);