Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c122e2a authored by Nikolay Borisov's avatar Nikolay Borisov Committed by David Sterba
Browse files

btrfs: Remove redundant extent_buffer_get in get_old_root 



get_old_root used used only by btrfs_search_old_slot to initialise the
path structure. The old root is always a cloned buffer (either via alloc
dummy or via btrfs_clone_extent_buffer) and its reference count is 2: 1
from allocation, 1 from extent_buffer_get call in get_old_root.

This latter explicit ref count acquire operation is in fact unnecessary
since the semantic is such that the newly allocated buffer is handed
over to the btrfs_path for lifetime management. Considering this just
remove the extra extent_buffer_get in get_old_root.

Signed-off-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 5c623d33

fs/btrfs/ctree.c

+0 −1
Original line number Diff line number Diff line
@@ -1362,7 +1362,6 @@ get_old_root(struct btrfs_root *root, u64 time_seq) 


	if (!eb)

		return NULL;

	extent_buffer_get(eb);

	btrfs_tree_read_lock(eb);

	if (old_root) {

		btrfs_set_header_bytenr(eb, eb->start);