Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6be54494 authored by Peter Rajnoha's avatar Peter Rajnoha Committed by Alasdair G Kergon
Browse files

dm ioctl: remove __dev_status from geometry and target message 



Remove useless __dev_status call while processing an ioctl that sets up
device geometry and target message.  The data is not returned to
userspace so there is no point collecting it and in the case of
target_message it is collected before processing the message so if it
did return it might be stale.

Signed-off-by: default avatarPeter Rajnoha <prajnoha@redhat.com>
Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
parent c2411045

drivers/md/dm-ioctl.c

+0 −6
Original line number Diff line number Diff line
@@ -818,8 +818,6 @@ static int dev_set_geometry(struct dm_ioctl *param, size_t param_size) 
	geometry.start = indata[3];



	r = dm_set_geometry(md, &geometry);

	if (!r)

		r = __dev_status(md, param);



	param->data_size = 0;
@@ -1333,10 +1331,6 @@ static int target_message(struct dm_ioctl *param, size_t param_size) 
	if (!md)

		return -ENXIO;



	r = __dev_status(md, param);

	if (r)

		goto out;



	if (tmsg < (struct dm_target_msg *) param->data ||

	    invalid_str(tmsg->message, (void *) param + param_size)) {

		DMWARN("Invalid target message parameters.");