Commit 6b7a3430 authored Jun 11, 2019 by Maxime Chevallier Committed by David S. Miller Jun 12, 2019

net: mvpp2: prs: Use the correct helpers when removing all VID filters



When removing all VID filters, the mvpp2_prs_vid_entry_remove would be
called with the TCAM id incorrectly used as a VID, causing the wrong
TCAM entries to be invalidated.

Fix this by directly invalidating entries in the VID range.

Fixes: 56beda3d ("net: mvpp2: Add hardware offloading for VLAN filtering")
Suggested-by: Yuri Chipchev <yuric@marvell.com>
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 46b0090a

drivers/net/ethernet/marvell/mvpp2/mvpp2_prs.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2025,8 +2025,10 @@ void mvpp2_prs_vid_remove_all(struct mvpp2_port *port)

		for (tid = MVPP2_PRS_VID_PORT_FIRST(port->id);
		tid <= MVPP2_PRS_VID_PORT_LAST(port->id); tid++) {
		if (priv->prs_shadow[tid].valid)
		mvpp2_prs_vid_entry_remove(port, tid);
		if (priv->prs_shadow[tid].valid) {
		mvpp2_prs_hw_inv(priv, tid);
		priv->prs_shadow[tid].valid = false;
		}
		}
		}