Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b701dab authored by Wang Ming's avatar Wang Ming Committed by Greg Kroah-Hartman
Browse files

firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe 



commit dd218433f2b635d97e8fda3eed047151fd528ce4 upstream.

The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.

Fixes: 7ca5ce89 ("firmware: add Intel Stratix10 service layer driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarWang Ming <machel@vivo.com>
Signed-off-by: default avatarDinh Nguyen <dinguyen@kernel.org>
Link: https://lore.kernel.org/r/20230727193750.983795-1-dinguyen@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bee7f3a4

drivers/firmware/stratix10-svc.c

+1 −1
Original line number Diff line number Diff line
@@ -616,7 +616,7 @@ svc_create_memory_pool(struct platform_device *pdev, 
	paddr = begin;

	size = end - begin;

	va = devm_memremap(dev, paddr, size, MEMREMAP_WC);

	if (!va) {

	if (IS_ERR(va)) {

		dev_err(dev, "fail to remap shared memory\n");

		return ERR_PTR(-EINVAL);

	}