Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b68e14e authored by Will Deacon's avatar Will Deacon Committed by Catalin Marinas
Browse files

arm64: debug: remove redundant spsr manipulation 



There is no need to explicitly clear the SS bit immediately before
setting it unconditionally.

Reported-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 2ce39ad1

arch/arm64/kernel/debug-monitors.c

+2 −11
Original line number Diff line number Diff line
@@ -165,21 +165,12 @@ postcore_initcall(debug_monitors_init); 
 */

static void set_regs_spsr_ss(struct pt_regs *regs)

{

	unsigned long spsr;



	spsr = regs->pstate;

	spsr &= ~DBG_SPSR_SS;

	spsr |= DBG_SPSR_SS;

	regs->pstate = spsr;

	regs->pstate |= DBG_SPSR_SS;

}



static void clear_regs_spsr_ss(struct pt_regs *regs)

{

	unsigned long spsr;



	spsr = regs->pstate;

	spsr &= ~DBG_SPSR_SS;

	regs->pstate = spsr;

	regs->pstate &= ~DBG_SPSR_SS;

}



/* EL1 Single Step Handler hooks */