Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b5c87f9 authored by Håkon Bugge's avatar Håkon Bugge Committed by Greg Kroah-Hartman
Browse files

RDMA/cma: Use output interface for net_dev check 



[ Upstream commit eb83f502adb036cd56c27e13b9ca3b2aabfa790b ]

Commit 27cfde795a96 ("RDMA/cma: Fix arguments order in net device
validation") swapped the src and dst addresses in the call to
validate_net_dev().

As a consequence, the test in validate_ipv4_net_dev() to see if the
net_dev is the right one, is incorrect for port 1 <-> 2 communication when
the ports are on the same sub-net. This is fixed by denoting the
flowi4_oif as the device instead of the incoming one.

The bug has not been observed using IPv6 addresses.

Fixes: 27cfde795a96 ("RDMA/cma: Fix arguments order in net device validation")
Signed-off-by: default avatarHåkon Bugge <haakon.bugge@oracle.com>
Link: https://lore.kernel.org/r/20221012141542.16925-1-haakon.bugge@oracle.com


Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a0d93849

drivers/infiniband/core/cma.c

+1 −1
Original line number Diff line number Diff line
@@ -1434,7 +1434,7 @@ static bool validate_ipv4_net_dev(struct net_device *net_dev, 
		return false;



	memset(&fl4, 0, sizeof(fl4));

	fl4.flowi4_iif = net_dev->ifindex;

	fl4.flowi4_oif = net_dev->ifindex;

	fl4.daddr = daddr;

	fl4.saddr = saddr;