Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b40d4c2 authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: displayport: Fix potential deadlock 



commit b791a67f68121d69108640d4a3e591d210ffe850 upstream.

The function ucsi_displayport_work() does not access the
connector, so it also must not acquire the connector lock.

This fixes a potential deadlock scenario:

ucsi_displayport_work() -> lock(&con->lock)
typec_altmode_vdm()
dp_altmode_vdm()
dp_altmode_work()
typec_altmode_enter()
ucsi_displayport_enter() -> lock(&con->lock)

Reported-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Fixes: af8622f6 ("usb: typec: ucsi: Support for DisplayPort alt mode")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240507134316.161999-1-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 46713954

drivers/usb/typec/ucsi/displayport.c

+0 −4
Original line number Diff line number Diff line
@@ -251,8 +251,6 @@ static void ucsi_displayport_work(struct work_struct *work) 
	struct ucsi_dp *dp = container_of(work, struct ucsi_dp, work);

	int ret;



	mutex_lock(&dp->con->lock);



	ret = typec_altmode_vdm(dp->alt, dp->header,

				dp->vdo_data, dp->vdo_size);

	if (ret)
@@ -261,8 +259,6 @@ static void ucsi_displayport_work(struct work_struct *work) 
	dp->vdo_data = NULL;

	dp->vdo_size = 0;

	dp->header = 0;



	mutex_unlock(&dp->con->lock);

}



void ucsi_displayport_remove_partner(struct typec_altmode *alt)