Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b292d78 authored by Jeff Layton's avatar Jeff Layton Committed by Greg Kroah-Hartman
Browse files

ceph: flush release queue when handling caps for unknown inode 

[ Upstream commit fb33c114d3ed5bdac230716f5b0a93b56b92a90d ]

It's possible for the VFS to completely forget about an inode, but for
it to still be sitting on the cap release queue. If the MDS sends the
client a cap message for such an inode, it just ignores it today, which
can lead to a stall of up to 5s until the cap release queue is flushed.

If we get a cap message for an inode that can't be located, then go
ahead and flush the cap release queue.

Cc: stable@vger.kernel.org
URL: https://tracker.ceph.com/issues/45532


Fixes: 1e9c2eb6 ("ceph: delete stale dentry when last reference is dropped")
Reported-and-Tested-by: default avatarAndrej Filipčič <andrej.filipcic@ijs.si>
Suggested-by: default avatarYan, Zheng <zyan@redhat.com>
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4d145e48

fs/ceph/caps.c

+1 −1
Original line number Diff line number Diff line
@@ -3938,7 +3938,7 @@ void ceph_handle_caps(struct ceph_mds_session *session, 
			__ceph_queue_cap_release(session, cap);

			spin_unlock(&session->s_cap_lock);

		}

		goto done;

		goto flush_cap_releases;

	}



	/* these will work even if we don't have a cap yet */