Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 6b27e277 authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown
Browse files

ASoC: stm32: sai: fix less than zero comparison on unsigned int 



Currently, the comparison of div < 0 is always false because div is
an unsigned int. Fix this by making div an int.

Detected by CoverityScan, CID#1475309 ("Unsigned compared against 0")

Fixes: 8307b2af "(ASoC: stm32: sai: set sai as mclk clock provider")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 65102238

sound/soc/stm/stm32_sai_sub.c

+1 −2
Original line number Diff line number Diff line
@@ -336,8 +336,7 @@ static int stm32_sai_mclk_set_rate(struct clk_hw *hw, unsigned long rate, 
{

	struct stm32_sai_mclk_data *mclk = to_mclk_data(hw);

	struct stm32_sai_sub_data *sai = mclk->sai_data;

	unsigned int div;

	int ret;

	int div, ret;



	div = stm32_sai_get_clk_div(sai, parent_rate, rate);

	if (div < 0)