Commit 6b0cb9c0 authored Aug 31, 2023 by Andy Shevchenko Committed by Greg Kroah-Hartman Sep 23, 2023

s390/zcrypt: don't leak memory if dev_set_name() fails



[ Upstream commit 6252f47b78031979ad919f971dc8468b893488bd ]

When dev_set_name() fails, zcdn_create() doesn't free the newly
allocated resources. Do it.

Fixes: 00fab235 ("s390/zcrypt: multiple zcrypt device nodes support")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230831110000.24279-1-andriy.shevchenko@linux.intel.com


Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c149b613

drivers/s390/crypto/zcrypt_api.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -397,6 +397,7 @@ static int zcdn_create(const char *name)
		ZCRYPT_NAME "_%d", (int) MINOR(devt));
		nodename[sizeof(nodename)-1] = '\0';
		if (dev_set_name(&zcdndev->device, nodename)) {
		kfree(zcdndev);
		rc = -EINVAL;
		goto unlockout;
		}