Commit 6abdf672 authored Nov 16, 2021 by Ye Guojin Committed by Greg Kroah-Hartman Jan 27, 2022

MIPS: OCTEON: add put_device() after of_find_device_by_node()



[ Upstream commit 858779df1c0787d3fec827fb705708df9ebdb15b ]

This was found by coccicheck:
./arch/mips/cavium-octeon/octeon-platform.c, 332, 1-7, ERROR missing
put_device; call of_find_device_by_node on line 324, but without a
corresponding object release within this function.
./arch/mips/cavium-octeon/octeon-platform.c, 395, 1-7, ERROR missing
put_device; call of_find_device_by_node on line 387, but without a
corresponding object release within this function.
./arch/mips/cavium-octeon/octeon-usb.c, 512, 3-9, ERROR missing
put_device; call of_find_device_by_node on line 515, but without a
corresponding object release within this function.
./arch/mips/cavium-octeon/octeon-usb.c, 543, 1-7, ERROR missing
put_device; call of_find_device_by_node on line 515, but without a
corresponding object release within this function.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2a8870f5

arch/mips/cavium-octeon/octeon-platform.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -328,6 +328,7 @@ static int __init octeon_ehci_device_init(void)

		pd->dev.platform_data = &octeon_ehci_pdata;
		octeon_ehci_hw_start(&pd->dev);
		put_device(&pd->dev);

		return ret;
		}
		@@ -391,6 +392,7 @@ static int __init octeon_ohci_device_init(void)

		pd->dev.platform_data = &octeon_ohci_pdata;
		octeon_ohci_hw_start(&pd->dev);
		put_device(&pd->dev);

		return ret;
		}

arch/mips/cavium-octeon/octeon-usb.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -544,6 +544,7 @@ static int __init dwc3_octeon_device_init(void)
		devm_iounmap(&pdev->dev, base);
		devm_release_mem_region(&pdev->dev, res->start,
		resource_size(res));
		put_device(&pdev->dev);
		}
		} while (node != NULL);