Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a806a21 authored by Sifan Naeem's avatar Sifan Naeem Committed by Mark Brown
Browse files

spi: img-spfi: fix support for speeds up to 1/4th input clock 



Setting the Same Edge bit indicates to the spfi block to receive and
transmit data on the same edge of the spfi clock, which in turn
doubles the operating frequency of spfi.

The maximum supported frequency is limited to 1/4th of the spfi input
clock, but without this bit set the maximum would be 1/8th of the
input clock.

The current driver calculates the divisor with maximum speed at 1/4th
of the input clock, this would fail if the requested frequency is
higher than 1/8 of the input clock. Any requests for 1/8th of the
input clock would still pass.

Fixes: 8543d0e7 ("spi: img-spfi: Limit bit clock to 1/4th of input clock")
Signed-off-by: default avatarSifan Naeem <sifan.naeem@imgtec.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: <stable@vger.kernel.org>
parent b787f68c

drivers/spi/spi-img-spfi.c

+2 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ 
#define SPFI_CONTROL_SOFT_RESET			BIT(11)

#define SPFI_CONTROL_SEND_DMA			BIT(10)

#define SPFI_CONTROL_GET_DMA			BIT(9)

#define SPFI_CONTROL_SE			BIT(8)

#define SPFI_CONTROL_TMODE_SHIFT		5

#define SPFI_CONTROL_TMODE_MASK			0x7

#define SPFI_CONTROL_TMODE_SINGLE		0
@@ -491,6 +492,7 @@ static void img_spfi_config(struct spi_master *master, struct spi_device *spi, 
	else if (xfer->tx_nbits == SPI_NBITS_QUAD &&

		 xfer->rx_nbits == SPI_NBITS_QUAD)

		val |= SPFI_CONTROL_TMODE_QUAD << SPFI_CONTROL_TMODE_SHIFT;

	val |= SPFI_CONTROL_SE;

	spfi_writel(spfi, val, SPFI_CONTROL);

}