Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a67b05c authored by Kailang Yang's avatar Kailang Yang Committed by Greg Kroah-Hartman
Browse files

ALSA: hda/realtek - Fixed HP right speaker no sound 



commit 5649625344fe1f4695eace7c37d011e317bf66d5 upstream.

HP NB right speaker had no sound output.
This platform was connected to I2S Amp for speaker out.(None Realtek I2S Amp IC)
EC need to check codec GPIO1 pin to initial I2S Amp.

Signed-off-by: default avatarKailang Yang <kailang@realtek.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/01285f623ac7447187482fb4a8ecaa7c@realtek.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 09832a9e

sound/pci/hda/patch_realtek.c

+18 −1
Original line number Diff line number Diff line
@@ -5940,6 +5940,16 @@ static void alc_fixup_disable_mic_vref(struct hda_codec *codec, 
		snd_hda_codec_set_pin_target(codec, 0x19, PIN_VREFHIZ);

}



static void  alc285_fixup_hp_gpio_amp_init(struct hda_codec *codec,

			      const struct hda_fixup *fix, int action)

{

	if (action != HDA_FIXUP_ACT_INIT)

		return;



	msleep(100);

	alc_write_coef_idx(codec, 0x65, 0x0);

}



/* for hda_fixup_thinkpad_acpi() */

#include "thinkpad_helper.c"
@@ -6120,6 +6130,7 @@ enum { 
	ALC289_FIXUP_ASUS_GA401,

	ALC289_FIXUP_ASUS_GA502,

	ALC256_FIXUP_ACER_MIC_NO_PRESENCE,

	ALC285_FIXUP_HP_GPIO_AMP_INIT,

};



static const struct hda_fixup alc269_fixups[] = {
@@ -7352,6 +7363,12 @@ static const struct hda_fixup alc269_fixups[] = { 
		.chained = true,

		.chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE

	},

	[ALC285_FIXUP_HP_GPIO_AMP_INIT] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_gpio_amp_init,

		.chained = true,

		.chain_id = ALC285_FIXUP_HP_GPIO_LED

	},

};



static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7502,7 +7519,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),

	SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),

	SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),

	SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),