Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a4f139a authored by Eli Cohen's avatar Eli Cohen Committed by David S. Miller
Browse files

mlx5: Fix sparse warnings 



1. Add required __acquire/__release statements to balance spinlock usage.
2. Change the index parameter of begin_wqe() to be unsigned to match supplied
argument type.

Signed-off-by: default avatarEli Cohen <eli@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 28c167fa

drivers/infiniband/hw/mlx5/qp.c

+15 −1
Original line number Diff line number Diff line
@@ -1011,9 +1011,14 @@ static void mlx5_ib_lock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *recv 
			}

		} else {

			spin_lock_irq(&send_cq->lock);

			__acquire(&recv_cq->lock);

		}

	} else if (recv_cq) {

		spin_lock_irq(&recv_cq->lock);

		__acquire(&send_cq->lock);

	} else {

		__acquire(&send_cq->lock);

		__acquire(&recv_cq->lock);

	}

}
@@ -1033,10 +1038,15 @@ static void mlx5_ib_unlock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *re 
				spin_unlock_irq(&recv_cq->lock);

			}

		} else {

			__release(&recv_cq->lock);

			spin_unlock_irq(&send_cq->lock);

		}

	} else if (recv_cq) {

		__release(&send_cq->lock);

		spin_unlock_irq(&recv_cq->lock);

	} else {

		__release(&recv_cq->lock);

		__release(&send_cq->lock);

	}

}
@@ -2411,7 +2421,7 @@ static u8 get_fence(u8 fence, struct ib_send_wr *wr) 


static int begin_wqe(struct mlx5_ib_qp *qp, void **seg,

		     struct mlx5_wqe_ctrl_seg **ctrl,

		     struct ib_send_wr *wr, int *idx,

		     struct ib_send_wr *wr, unsigned *idx,

		     int *size, int nreq)

{

	int err = 0;
@@ -2737,6 +2747,8 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, 


		if (bf->need_lock)

			spin_lock(&bf->lock);

		else

			__acquire(&bf->lock);



		/* TBD enable WC */

		if (0 && nreq == 1 && bf->uuarn && inl && size > 1 && size <= bf->buf_size / 16) {
@@ -2753,6 +2765,8 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, 
		bf->offset ^= bf->buf_size;

		if (bf->need_lock)

			spin_unlock(&bf->lock);

		else

			__release(&bf->lock);

	}



	spin_unlock_irqrestore(&qp->sq.lock, flags);