Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a421928 authored by Tomi Valkeinen's avatar Tomi Valkeinen Committed by Greg Kroah-Hartman
Browse files

drm/bridge: tc358767: Fix return value on error case 



[ Upstream commit 32bd29b619638256c5b75fb021d6d9f12fc4a984 ]

If the hpd_pin is invalid, the driver returns 'ret'. But 'ret' contains
0, instead of an error value.

Return -EINVAL instead.

Fixes: f25ee501 ("drm/bridge: tc358767: add IRQ and HPD support")
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103-uninit-fixes-v2-4-c22b2444f5f5@ideasonboard.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d46fe2e9

drivers/gpu/drm/bridge/tc358767.c

+1 −1
Original line number Diff line number Diff line
@@ -1574,7 +1574,7 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id) 
	} else {

		if (tc->hpd_pin < 0 || tc->hpd_pin > 1) {

			dev_err(dev, "failed to parse HPD number\n");

			return ret;

			return -EINVAL;

		}

	}