Commit 6a11f0f5 authored Jul 15, 2019 by Fuqian Huang Committed by Mauro Carvalho Chehab Aug 13, 2019

media: ngene: Remove call to memset after pci_alloc_consistent



pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f19
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent e6714993

drivers/media/pci/ngene/ngene-core.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -854,8 +854,6 @@ static int create_ring_buffer(struct pci_dev *pci_dev,
		if (!Head)
		return -ENOMEM;

		memset(Head, 0, MemSize);

		PARingBufferCur = PARingBufferHead;
		Cur = Head;

		@@ -907,8 +905,6 @@ static int AllocateRingBuffers(struct pci_dev *pci_dev,
		if (SCListMem == NULL)
		return -ENOMEM;

		memset(SCListMem, 0, SCListMemSize);

		pRingBuffer->SCListMem = SCListMem;
		pRingBuffer->PASCListMem = PASCListMem;
		pRingBuffer->SCListMemSize = SCListMemSize;