davinci: make it easier to identify SoC init failures (69872e93) · Commits · e / devices / android_kernel_fairphone_FP5

This patch makes it easier to identify SoC init failures by panicing when SoC init fails. Without successful SoC init, the kernel eventually fails when attempt is made to access the clocks. Also, an error is printed when JTAG ID match fails to make it easier to identify failures due to SoC rev changes. Signed-off-by:

Sekhar Nori <nsekhar@ti.com> Signed-off-by:

Kevin Hilman <khilman@deeprootsystems.com>

arch/arm/mach-davinci/common.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -86,6 +86,8 @@ void __init davinci_common_init(struct davinci_soc_info *soc_info)
	dip = davinci_get_id(davinci_soc_info.jtag_id);		dip = davinci_get_id(davinci_soc_info.jtag_id);
	if (!dip) {		if (!dip) {
	ret = -EINVAL;		ret = -EINVAL;
			pr_err("Unknown DaVinci JTAG ID 0x%x\n",
			davinci_soc_info.jtag_id);
	goto err;		goto err;
	}		}

	@@ -104,5 +106,5 @@ void __init davinci_common_init(struct davinci_soc_info *soc_info)
	return;		return;

	err:		err:
	pr_err("davinci_common_init: SoC Initialization failed\n");		panic("davinci_common_init: SoC Initialization failed\n");
	}		}