Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69696951 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

iio: ssp_sensors: fix error code in ssp_print_mcu_debug() 



commit 4170d3dd1467e9d78cb9af374b19357dc324b328 upstream.

The ssp_print_mcu_debug() function should return negative error codes on
error.  Returning "length" is meaningless.  This change does not affect
runtime because the callers only care about zero/non-zero.

Reported-by: default avatarJonathan Cameron <jic23@kernel.org>
Fixes: 50dd64d5 ("iio: common: ssp_sensors: Add sensorhub driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210914105333.GA11657@kili


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 10ecff15

drivers/iio/common/ssp_sensors/ssp_spi.c

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static int ssp_print_mcu_debug(char *data_frame, int *data_index, 
	if (length > received_len - *data_index || length <= 0) {

		ssp_dbg("[SSP]: MSG From MCU-invalid debug length(%d/%d)\n",

			length, received_len);

		return length ? length : -EPROTO;

		return -EPROTO;

	}



	ssp_dbg("[SSP]: MSG From MCU - %s\n", &data_frame[*data_index]);