Commit 69555bb2 authored Apr 21, 2022 by liuyacan Committed by Greg Kroah-Hartman May 09, 2022

net/smc: sync err code when tcp connection was refused



[ Upstream commit 4e2e65e2e56c6ceb4ea1719360080c0af083229e ]

In the current implementation, when TCP initiates a connection
to an unavailable [ip,port], ECONNREFUSED will be stored in the
TCP socket, but SMC will not. However, some apps (like curl) use
getsockopt(,,SO_ERROR,,) to get the error information, which makes
them miss the error message and behave strangely.

Fixes: 50717a37 ("net/smc: nonblocking connect rework")
Signed-off-by: liuyacan <liuyacan@corp.netease.com>
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent daca2384

net/smc/af_smc.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -816,6 +816,8 @@ static void smc_connect_work(struct work_struct *work)
		smc->sk.sk_state = SMC_CLOSED;
		if (rc == -EPIPE \|\| rc == -EAGAIN)
		smc->sk.sk_err = EPIPE;
		else if (rc == -ECONNREFUSED)
		smc->sk.sk_err = ECONNREFUSED;
		else if (signal_pending(current))
		smc->sk.sk_err = -sock_intr_errno(timeo);
		sock_put(&smc->sk); /* passive closing */