Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 692d79e1 authored by Kristina Martšenko's avatar Kristina Martšenko Committed by Greg Kroah-Hartman
Browse files

staging: sbe-2t3e3: remove t3e3_rx_desc_t typedef 



Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_rx_desc_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:616: WARNING: do not add new typedefs

Signed-off-by: default avatarKristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 10a0e2e2

drivers/staging/sbe-2t3e3/2t3e3.h

+3 −3
Original line number Diff line number Diff line
@@ -613,12 +613,12 @@ 
 * descriptor list and data buffer

 *

 **********************************************************************/

typedef struct {

struct t3e3_rx_desc {

	u32 rdes0;

	u32 rdes1;

	u32 rdes2;

	u32 rdes3;

} t3e3_rx_desc_t;

};



#define SBE_2T3E3_RX_DESC_RING_SIZE			64
@@ -723,7 +723,7 @@ struct channel { 
		u32 interrupt_enable_mask;



		/* receive chain/ring */

		t3e3_rx_desc_t *rx_ring;

		struct t3e3_rx_desc *rx_ring;

		struct sk_buff *rx_data[SBE_2T3E3_RX_DESC_RING_SIZE];

		u32 rx_ring_current_read;

drivers/staging/sbe-2t3e3/dc.c

+1 −1
Original line number Diff line number Diff line
@@ -316,7 +316,7 @@ static int dc_init_descriptor_list(struct channel *sc) 


	if (sc->ether.rx_ring == NULL)

		sc->ether.rx_ring = kcalloc(SBE_2T3E3_RX_DESC_RING_SIZE,

					    sizeof(t3e3_rx_desc_t), GFP_KERNEL);

					    sizeof(struct t3e3_rx_desc), GFP_KERNEL);

	if (sc->ether.rx_ring == NULL)

		return -ENOMEM;

drivers/staging/sbe-2t3e3/intr.c

+1 −1
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ void dc_intr_rx(struct channel *sc) 
{

	u32 current_read;

	u32 error_mask, error;

	t3e3_rx_desc_t *current_desc;

	struct t3e3_rx_desc *current_desc;

	struct sk_buff *m, *m2;

	unsigned rcv_len;