Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68e54d9e authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Greg Kroah-Hartman
Browse files

drivers: mcb: fix resource leak in mcb_probe() 



[ Upstream commit d7237462561fcd224fa687c56ccb68629f50fc0d ]

When probe hook function failed in mcb_probe(), it doesn't put the device.
Compiled test only.

Fixes: 7bc36409 ("mcb: Acquire reference to device in probe")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: default avatarJohannes Thumshirn <jth@kernel.org>
Link: https://lore.kernel.org/r/9f87de36bfb85158b506cb78c6fc9db3f6a3bad1.1669624063.git.johannes.thumshirn@wdc.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 80dc47e7

drivers/mcb/mcb-core.c

+3 −1
Original line number Diff line number Diff line
@@ -71,8 +71,10 @@ static int mcb_probe(struct device *dev) 


	get_device(dev);

	ret = mdrv->probe(mdev, found_id);

	if (ret)

	if (ret) {

		module_put(carrier_mod);

		put_device(dev);

	}



	return ret;

}