Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68b7587b authored by Axel Lin's avatar Axel Lin Committed by Bartosz Golaszewski
Browse files

gpio: altera-a10sr: Trivial coding style fix 



Change the coding style to make it does error checking first.
This also fixes checkpatch warning about line over 80 characters.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Tested by: Thor Thayer <thor.thayer@linux.intel.com>
Reviewed by: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 69118452

drivers/gpio/gpio-altera-a10sr.c

+9 −8
Original line number Diff line number Diff line
@@ -58,20 +58,21 @@ static void altr_a10sr_gpio_set(struct gpio_chip *chip, unsigned int offset, 
static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,

					   unsigned int nr)

{

	if (nr >= (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT))

		return 0;

	if (nr < (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT))

		return -EINVAL;



	return 0;

}



static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,

					    unsigned int nr, int value)

{

	if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) {

	if (nr > (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))

		return -EINVAL;



	altr_a10sr_gpio_set(gc, nr, value);

	return 0;

}

	return -EINVAL;

}



static const struct gpio_chip altr_a10sr_gc = {

	.label = "altr_a10sr_gpio",