Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 683585ad authored by Yuchao Ma's avatar Yuchao Ma Committed by Gerrit - the friendly Code Review server
Browse files

disp: msm: sde: remove checks in LTM hist disable function 



The right_mixer and hist_en checks in LTM hist disable function are
not valid for dual display use cases, since in dual display use cases,
right_mixer will always be NULL.
When device enters suspend state, hist_en will be set to false in
sde_cp_crtc_suspend(), and together with the right_mixer check,
it will block the ltm buffer lists from resetting and cause LTM has
no buffers to use after resume.

Change-Id: I51b1b00f4af59e42105322de68019479c65f2fbb
Signed-off-by: default avatarYuchao Ma <yuchaom@codeaurora.org>
parent 6a9e397c

msm/sde/sde_color_processing.c

+0 −6
Original line number Diff line number Diff line
@@ -2876,15 +2876,9 @@ static void _sde_cp_crtc_disable_ltm_hist(struct sde_crtc *sde_crtc, 
	struct sde_hw_dspp *hw_dspp, struct sde_hw_cp_cfg *hw_cfg)

{

	unsigned long irq_flags;

	struct sde_hw_mixer *hw_lm = hw_cfg->mixer_info;

	u32 i = 0;



	spin_lock_irqsave(&sde_crtc->ltm_lock, irq_flags);

	if (!hw_lm->cfg.right_mixer && !sde_crtc->ltm_hist_en) {

		/* histogram is already disabled */

		spin_unlock_irqrestore(&sde_crtc->ltm_lock, irq_flags);

		return;

	}

	sde_crtc->ltm_hist_en = false;

	INIT_LIST_HEAD(&sde_crtc->ltm_buf_free);

	INIT_LIST_HEAD(&sde_crtc->ltm_buf_busy);