Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6827b58a authored by Thinh Nguyen's avatar Thinh Nguyen Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: gadget: Don't set IMI for no_interrupt 



commit 308c316d16cbad99bb834767382baa693ac42169 upstream.

The gadget driver may have a certain expectation of how the request
completion flow should be from to its configuration. Make sure the
controller driver respect that. That is, don't set IMI (Interrupt on
Missed Isoc) when usb_request->no_interrupt is set. Also, the driver
should only set IMI to the last TRB of a chain.

Fixes: 72246da4 ("usb: Introduce DesignWare USB3 DRD Driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Reviewed-by: default avatarJeff Vanhoof <jdv1029@gmail.com>
Tested-by: default avatarJeff Vanhoof <jdv1029@gmail.com>
Link: https://lore.kernel.org/r/ced336c84434571340c07994e3667a0ee284fefe.1666735451.git.Thinh.Nguyen@synopsys.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9aa02543

drivers/usb/dwc3/gadget.c

+2 −2
Original line number Diff line number Diff line
@@ -981,7 +981,7 @@ static void __dwc3_prepare_one_trb(struct dwc3_ep *dep, struct dwc3_trb *trb, 
			trb->ctrl = DWC3_TRBCTL_ISOCHRONOUS;

		}



		/* always enable Interrupt on Missed ISOC */

		if (!no_interrupt && !chain)

			trb->ctrl |= DWC3_TRB_CTRL_ISP_IMI;

		break;