Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68203a67 authored by Rahul Verma's avatar Rahul Verma Committed by David S. Miller
Browse files

qed: Fix static checker warning 



	Static Checker Warnings:
	drivers/net/ethernet/qlogic/qed/qed_main.c:1510 qed_fill_link_capability()
	error: uninitialized symbol 'tcvr_state'.
	drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
	error: uninitialized symbol 'transceiver_state'.
	drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
	error: uninitialized symbol 'transceiver_type'.

	Symbols tcvr_state, transceiver_state and transceiver_type
	are initialized with respective default state.

Fixes: c56a8be7 ("qed: Add supported link and advertise link to display in ethtool.")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRahul Verma <Rahul.Verma@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5ef79151

drivers/net/ethernet/qlogic/qed/qed_mcp.c

+3 −3
Original line number Diff line number Diff line
@@ -1900,6 +1900,9 @@ int qed_mcp_get_transceiver_data(struct qed_hwfn *p_hwfn, 
{

	u32 transceiver_info;



	*p_transceiver_type = ETH_TRANSCEIVER_TYPE_NONE;

	*p_transceiver_state = ETH_TRANSCEIVER_STATE_UPDATING;



	if (IS_VF(p_hwfn->cdev))

		return -EINVAL;
@@ -1908,9 +1911,6 @@ int qed_mcp_get_transceiver_data(struct qed_hwfn *p_hwfn, 
		return -EBUSY;

	}



	*p_transceiver_type = ETH_TRANSCEIVER_TYPE_NONE;

	*p_transceiver_state = ETH_TRANSCEIVER_STATE_UPDATING;



	transceiver_info = qed_rd(p_hwfn, p_ptt,

				  p_hwfn->mcp_info->port_addr +

				  offsetof(struct public_port,