Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6814b590 authored by Peng Li's avatar Peng Li Committed by David S. Miller
Browse files

net: hns3: code optimization for command queue' spin lock 



This patch removes some redundant BH disable when initializing
and uninitializing command queue.

Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cc5ff6e9

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

+2 −2
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ int hclge_cmd_init(struct hclge_dev *hdev) 
	int ret;



	spin_lock_bh(&hdev->hw.cmq.csq.lock);

	spin_lock_bh(&hdev->hw.cmq.crq.lock);

	spin_lock(&hdev->hw.cmq.crq.lock);



	hdev->hw.cmq.csq.next_to_clean = 0;

	hdev->hw.cmq.csq.next_to_use = 0;
@@ -364,7 +364,7 @@ int hclge_cmd_init(struct hclge_dev *hdev) 


	hclge_cmd_init_regs(&hdev->hw);



	spin_unlock_bh(&hdev->hw.cmq.crq.lock);

	spin_unlock(&hdev->hw.cmq.crq.lock);

	spin_unlock_bh(&hdev->hw.cmq.csq.lock);



	clear_bit(HCLGE_STATE_CMD_DISABLE, &hdev->state);

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c

+2 −2
Original line number Diff line number Diff line
@@ -334,7 +334,7 @@ int hclgevf_cmd_init(struct hclgevf_dev *hdev) 
	int ret;



	spin_lock_bh(&hdev->hw.cmq.csq.lock);

	spin_lock_bh(&hdev->hw.cmq.crq.lock);

	spin_lock(&hdev->hw.cmq.crq.lock);



	/* initialize the pointers of async rx queue of mailbox */

	hdev->arq.hdev = hdev;
@@ -348,7 +348,7 @@ int hclgevf_cmd_init(struct hclgevf_dev *hdev) 


	hclgevf_cmd_init_regs(&hdev->hw);



	spin_unlock_bh(&hdev->hw.cmq.crq.lock);

	spin_unlock(&hdev->hw.cmq.crq.lock);

	spin_unlock_bh(&hdev->hw.cmq.csq.lock);



	clear_bit(HCLGEVF_STATE_CMD_DISABLE, &hdev->state);