Commit 67d8208f authored Dec 16, 2018 by Christoph Hellwig Committed by Michael Ellerman Dec 20, 2018

crypto4xx_core: don't abuse __dma_sync_page



This function is internal to the DMA API implementation. Instead use
the DMA API to properly unmap. Note that the DMA API usage in this
driver is a disaster and urgently needs some work - it is missing all
the unmaps, seems to do a secondary map where it looks like it should
to a unmap in one place to work around cache coherency and the
directions passed in seem to be partially wrong.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 0aeba2d0

drivers/crypto/amcc/crypto4xx_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -596,7 +596,7 @@ static void crypto4xx_aead_done(struct crypto4xx_device *dev,
		pd->pd_ctl_len.bf.pkt_len,
		dst);
		} else {
		__dma_sync_page(sg_page(dst), dst->offset, dst->length,
		dma_unmap_page(dev->core_dev->device, pd->dest, dst->length,
		DMA_FROM_DEVICE);
		}